FIX: Update Discobot's UserProfile#bio_raw when default locale changes
#26045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| next if profile.blank? | ||
|
|
||
| new_bio = I18n.with_locale(new_value) { I18n.t("discourse_narrative_bot.bio") } | ||
| profile.update!(bio_raw: new_bio) if profile.bio_raw != new_bio |
There was a problem hiding this comment.
Extremely minor, but I wonder if AR will prevent this kind of noop before reaching out to the DB?
There was a problem hiding this comment.
O good catch! AR actually does a noop.
[5] pry(main)> profile.update!(bio_raw: profile.bio_raw)
TRANSACTION (0.2ms) BEGIN
User Load (4.1ms) SELECT "users".* FROM "users" WHERE "users"."id" = -2 LIMIT 1
TRANSACTION (0.2ms) COMMIT
=> true
tgxworld
force-pushed
the
update_discobot_bio_raw_when_default_locale_changes
branch
from
f5fd054
to
2f1ecd2
Compare
Why this change? When a site's default locale is changed, Discobot's `UserProfile#bio_raw` is not changed and we have gotten reports about this. What does this change do? This change adds a `DiscourseEvent.on(:site_setting_changed)` callback which watches for changes to the `default_locale` site setting and updates Discobot's `UserProfile#bio_raw` when it changes.
tgxworld
force-pushed
the
update_discobot_bio_raw_when_default_locale_changes
branch
from
2f1ecd2
to
ef831ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change?
When a site's default locale is changed, Discobot's
UserProfile#bio_rawis notchanged and we have gotten reports about this.
What does this change do?
This change adds a
DiscourseEvent.on(:site_setting_changed)callbackwhich watches for changes to the
default_localesite setting andupdates Discobot's
UserProfile#bio_rawwhen it changes.