Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: improves linking of thread messages #26095

Merged
merged 1 commit into from Mar 8, 2024

Conversation

jjaffeux
Copy link
Contributor

@jjaffeux jjaffeux commented Mar 7, 2024

  • The thread preview is now a regular link and can be right clicked
  • left gutter date, and regular date of a thread message will not correctly link to the thread's message

- The thread preview is now a regular link and can be right clicked
- left gutter date, and regular date of a thread message will not correctly link to the thread's message
@jjaffeux jjaffeux requested a review from dbattersby March 7, 2024 22:58
@github-actions github-actions bot added the chat PRs which include a change to Chat plugin label Mar 7, 2024
@jjaffeux
Copy link
Contributor Author

jjaffeux commented Mar 7, 2024

@dbattersby can you look at this one please?

Copy link
Contributor

@dbattersby dbattersby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice one 👍

@jjaffeux jjaffeux merged commit 21a7ebf into discourse:main Mar 8, 2024
16 checks passed
@jjaffeux jjaffeux deleted the chat/thread-links branch March 8, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chat PRs which include a change to Chat plugin
2 participants