Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: filter additional keywords for the sidebar #26148

Merged
merged 8 commits into from Mar 14, 2024

Conversation

lis2
Copy link
Contributor

@lis2 lis2 commented Mar 12, 2024

With the new admin sidebar restructure, we have a link to "Installed plugins". We would like to ensure that when the admin is searching for a plugin name like "akismet" or "automation" this link will be visible.

Also when entering the plugins page, related plugins should be highlighted.

Demo

Screen.Recording.2024-03-12.at.2.49.22.PM.mov

Copy link
Contributor

@martin-brennan martin-brennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your thinking with the keywords here, but I think:

image

Since at some point we want to make an admin global search, and you have already been experimenting with site setting search from the sidebar, it might be worth allowing for a bit more depth in your keywords. Something like:

keywords: {
   admin_installed_plugins: {  navigation: ["chat", "ai", ...], relatedSettings: ["enable_chat", "enable_discourse_ai", ... },
   experimental: { relatedSettings: ["experimental_setting_name_1", "experimental_setting_name_2"] },
   "admin_plugin_discourse-ai": { relatedSettings: ["every_single", "ai_setting" ] }
}

A simplified version of the site settings (just name and description) could be preloaded for admins in the application controller in future to allow for this, or even just a server-side portion of sidebar/admin-nav-map.js to match up nav items to site settings.

Anyway the point is, we should allow for a bit more depth by using objects for each sidebar keyword group from the start :)

@martin-brennan
Copy link
Contributor

Overall I really like this, seeing the plugin highlighted in the list is so great, and the settings will be the icing of the cake. It's going to be so much easier to find stuff in the admin portal 😭

@github-actions github-actions bot added the chat PRs which include a change to Chat plugin label Mar 13, 2024
With the new admin sidebar restructure, we have a link to "Installed plugins". We would like to ensure that when the admin is searching for a plugin name like "akismet" or "automation" this link will be visible. Also when entering the plugins page, related plugins should be highlighted.
@lis2 lis2 force-pushed the new-keywords-filter branch 2 times, most recently from 8906a31 to 6441296 Compare March 13, 2024 06:00
Copy link
Contributor

@martin-brennan martin-brennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one more minor thing, but otherwise LGTM, thanks for making changes :)

@lis2 lis2 merged commit 9afb0b2 into discourse:main Mar 14, 2024
16 checks passed
@lis2 lis2 deleted the new-keywords-filter branch March 14, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chat PRs which include a change to Chat plugin staff-experience
2 participants