DEV: Catch missing translations during test runs #26258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
approved these changes
Mar 20, 2024
Drenmi
force-pushed
the
dev/catch-missing-translations-during-test-runs
branch
from
abceb02
to
78832c2
Compare
Drenmi
commented
Mar 20, 2024
| @@ -122,7 +122,8 @@ def translate_no_override(key, options) | |||
| dup_options = nil | |||
| if options | |||
| dup_options = options.dup | |||
| should_raise = dup_options.delete(:raise) | |||
| should_raise = | |||
| dup_options.delete(:raise) || Rails.application.config.i18n.raise_on_missing_translations | |||
There was a problem hiding this comment.
A little bit of coupling here, but that's because our freedom patch isn't made to work with the built-in exception handler, which is how the Railtie makes this connection normally.
Drenmi
force-pushed
the
dev/catch-missing-translations-during-test-runs
branch
from
d533949
to
bc82ccd
Compare
github-actions
bot
added
the
i18n
Drenmi
commented
Apr 8, 2024
| @@ -282,7 +282,7 @@ def stub_empty_referred_topics_data | |||
| it "returns localized titles" do | |||
| stub_empty_referred_topics_data | |||
| expect(top_referred_topics[:title]).to be_present | |||
| expect(top_referred_topics[:xaxis]).to be_present | |||
There was a problem hiding this comment.
The reason this was "present" is because it was a string: "Missing translation for ...", which misses the intent of the test.
Drenmi
force-pushed
the
dev/catch-missing-translations-during-test-runs
branch
9 times, most recently
from
b83afa1
to
800afe2
Compare
Drenmi
force-pushed
the
dev/catch-missing-translations-during-test-runs
branch
2 times, most recently
from
f72614d
to
e9b3a52
Compare
Drenmi
force-pushed
the
dev/catch-missing-translations-during-test-runs
branch
from
e9b3a52
to
85c679e
Compare
Drenmi
force-pushed
the
dev/catch-missing-translations-during-test-runs
branch
from
85c679e
to
0cf7bf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
This configuration makes it so that a missing translation will raise an error during test execution. Better discover there than after deploy.