Add RTL support to Discourse CSS Theme #2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd configurable via discourse.conf
|
Thanks for contributing this pull request! Could you please sign our CLA so we can review it? http://www.discourse.org/cla |
| @@ -154,6 +154,7 @@ gem 'rack-protection' # security | |||
| group :assets do | |||
| gem 'sass-rails', '~> 4.0.2' | |||
| gem 'uglifier' | |||
| gem 'rtlit' # for css rtling | |||
There was a problem hiding this comment.
this needs to be require: false
|
@SamSaffron thanks! We're really waiting for this, can you please review the new committs? Thanks, Benny |
|
Sorry about this, yes looks fine, thanks |
SamSaffron
added a commit
that referenced
this pull request
Aug 22, 2014
Add RTL support to Discourse CSS Theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add RTL support for Discourse CSS theme using the RTLit gem, which automatically converts CSS to RTL during pre-processing stage. RTL can be enabled / disabled via configuration parameter in config/discourse.conf and is opt-in (i.e. disabled by default)