DEV: Add AsyncCategoryLink component #26451
Draft
+36
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renders a category link, but is also responsible for fetching the category.
pmusaraj
reviewed
Apr 5, 2024
| import categoryLink from "discourse/helpers/category-link"; | ||
| import Category from "discourse/models/category"; | ||
|
|
||
| export default class AsyncCategoryLink extends Component { |
There was a problem hiding this comment.
Overall this makes sense. But naming is tricky, I think in the long run we don't necessarily want to keep Async in the name. Can we use CategoryLink? There might be a naming conflict with the helper, not sure.
Would be great to also test in how many places we can replace the helper with this component.
One more thing: it would be good to have this represented in the styleguide. The category badge screen there needs some love anyway.
|
This pull request has been automatically marked as stale because it has been open for 60 days with no activity. To keep it open, remove the stale tag, push code, or add a comment. Otherwise, it will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renders a category link, but is also responsible for fetching the category.