Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX: Display JIT when user list is empty #26579

Merged
merged 3 commits into from
Apr 9, 2024
Merged

UX: Display JIT when user list is empty #26579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea42a71
UX: Display JIT when user list is empty
ellaestigoy Apr 9, 2024
3837c5e
UX: Remove empty state heading
ellaestigoy Apr 9, 2024
1c32270
DEV: add spacing by enclosing empty state body in <p> tag
ellaestigoy Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 14 additions & 2 deletions app/assets/javascripts/discourse/app/templates/users.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,20 @@
/>
<ConditionalLoadingSpinner @condition={{this.model.loadingMore}} />
{{else}}
<div class="clearfix"></div>
<p>{{i18n "directory.no_results"}}</p>
<div class="empty-state">
<div class="empty-state-body">
<p>
{{i18n "directory.no_results.body"}}
{{#if this.currentUser.staff}}
{{html-safe
(i18n
"directory.no_results.extra_body" basePath=(base-path)
)
}}
{{/if}}
</p>
</div>
</div>
{{/if}}
</ConditionalLoadingSpinner>
</div>
Expand Down
4 changes: 3 additions & 1 deletion config/locales/client.en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,7 +763,9 @@ en:
topic_count_long: "Topics Created"
post_count: "Replies"
post_count_long: "Replies Posted"
no_results: "No results were found."
no_results:
body: "A list of community members showing their activity will be shown here. For now the list is empty because your community is still brand new!"
extra_body: "Admins and moderators can see and manage users in <a href='%{basePath}/admin/users/'>User Admin</a>."
days_visited: "Visits"
days_visited_long: "Days Visited"
posts_read: "Read"
Expand Down