Fix: allow staff and direct message enabled groups to create personal chats

[pangbo13]

As an admin, I am unable to create personal chats with other users.

However, according to the site settings, staff members should always have the ability to create personal chats.

Steps to reproduce:

1. Set chat allowed groups to TL0 & direct message enabled groups to moderators
2. As an admin, attempt to create a personal chat with a TL1 user.

Fix

This issue is related to PR #26010

discourse/plugins/chat/app/serializers/chat/chatable_user_serializer.rb

Line 8 in df373d9

SiteSetting.chat_enabled && object.guardian.can_chat? && object.guardian.can_direct_message?

When a user attempts to create a personal chat, we should not verify whether the target user has the ability to create personal chats. Instead, as specified in the site settings, we should verify whether the current user has the ability to create personal chats.

As long as the current user is a member of the direct message enabled groups or is a staff member, they should be able to create a personal chat.

[discoursebot]

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/cant-create-personal-chats-as-an-admin/304220/1