PERF: Reduce overhead from chat message excerpt #26712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbattersby
force-pushed
the
chat-message-excerpt-improvements
branch
3 times, most recently
from
0684bc4
to
9723c7e
Compare
dbattersby
force-pushed
the
chat-message-excerpt-improvements
branch
from
9723c7e
to
e875ee7
Compare
dbattersby
commented
Apr 24, 2024
dbattersby
commented
Apr 24, 2024
dbattersby
commented
Apr 24, 2024
jjaffeux
reviewed
Apr 24, 2024
jjaffeux
reviewed
Apr 24, 2024
jjaffeux
reviewed
Apr 24, 2024
dbattersby
commented
Apr 24, 2024
jjaffeux
approved these changes
Apr 25, 2024
jjaffeux
reviewed
Apr 25, 2024
dbattersby
added a commit
that referenced
this pull request
Apr 26, 2024
Follow up to #26712 to account for older threads that don't have a persisted excerpt, as this was previously generated on every page load. This change allows us to build the excerpt on the fly when none exists, fixing the issue of missing message excerpts for thread previews (within channel) and thread lists (on mobile/desktop).
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/chat-replies-missing-excerpt/305991/2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the chat message excerpt into a new database column (string) on the chat_messages table.
As part of this change, we will now set the excerpt within the
Chat::CreateMessageservice, and update it within theChat::UpdateMessageservice.