DEV: add support for adding custom status filter #26770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those can be used in the /filter routes.
ZogStriP
added a commit
to discourse/discourse-solved
that referenced
this pull request
Apr 26, 2024
Those can be used in /filter route. Depends on discourse/discourse#26770 Internal ref. /t/127278
ZogStriP
added a commit
to discourse/discourse-solved
that referenced
this pull request
Apr 26, 2024
Those can be used in /filter route. Depends on discourse/discourse#26770 Internal ref. /t/127278
jjaffeux
approved these changes
Apr 26, 2024
ZogStriP
added a commit
to discourse/discourse-solved
that referenced
this pull request
Apr 26, 2024
* FEATURE: add new custom status filters Those can be used in /filter route. Depends on discourse/discourse#26770 Internal ref. /t/127278 * DEV: pin plugin for Discourse 3.3.0.beta2-dev
tgxworld
reviewed
Apr 29, 2024
| fab!(:foobar_topic) { Fabricate(:topic, closed: true, word_count: 42) } | ||
|
|
||
| it "supports custom status filters" do | ||
| TopicsFilter.add_filter_by_status("foobar") { |scope| scope.where("word_count = 42") } |
There was a problem hiding this comment.
We need to clean up this state so that it doesn't leak across tests.
There was a problem hiding this comment.
Will be fixed in #26803
ZogStriP
added a commit
that referenced
this pull request
Apr 29, 2024
Ensures we clean up any custom filters added in the specs to prevent any leaks when running the specs. Follow up to #26770 (comment)
ZogStriP
added a commit
that referenced
this pull request
Apr 29, 2024
Ensures we clean up any custom filters added in the specs to prevent any leaks when running the specs. Follow up to #26770 (comment)
ZogStriP
added a commit
that referenced
this pull request
Apr 29, 2024
Ensures we clean up any custom filters added in the specs to prevent any leaks when running the specs. Follow up to #26770 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those can be used in the /filter routes.