Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: admin sidebar headings are bold #26801

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

lis2
Copy link
Contributor

@lis2 lis2 commented Apr 29, 2024

Make admin sidebar headings bold.

Admin screenshot
Screenshot 2024-04-29 at 4 17 20 PM

Original sidebar headers are untouched
Screenshot 2024-04-29 at 4 17 38 PM

Make admin sidebar headings bold.
@lis2 lis2 merged commit 0842ca7 into discourse:main Apr 29, 2024
16 checks passed
@lis2 lis2 deleted the admin-sidebar-css branch April 29, 2024 23:31
@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/css-is-different-broken-in-some-areas-such-as-in-admin-and-category-banner/307354/2

lis2 added a commit to lis2/discourse that referenced this pull request May 13, 2024
Recently a bug was introduced when the admin sidebar section was made bold.

When the admin sidebar is disabled, we display the original sidebar in the admin panel. In that case, an incorrect CSS rule is executed.
```CSS
.admin-area .sidebar-wrapper {
  background-color: var(--d-sidebar-admin-background);
  .sidebar-section-header-text {
    font-weight: bold;
  }
}
```
Bug in this PR: discourse#26801

To solve it, a custom CSS class with a panel key was added which will allow granular customisations.
lis2 added a commit that referenced this pull request May 13, 2024
Recently a bug was introduced when the admin sidebar section was made bold.

When the admin sidebar is disabled, we display the original sidebar in the admin panel. In that case, an incorrect CSS rule is executed.
```CSS
.admin-area .sidebar-wrapper {
  background-color: var(--d-sidebar-admin-background);
  .sidebar-section-header-text {
    font-weight: bold;
  }
}
```
Bug in this PR: #26801

To solve it, a custom CSS class with a panel key was added which will allow granular customisations.
@discourse discourse deleted a comment from Stam098c May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants