FIX: group activity's mentions infinite loading #27070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 07ecbb5 we ensure the mentions in a group's activity page worked properly but we missed adding proper support for infinite loading. The client is using the `before` parameter instead of the `before_post_id` to do the pagination. This adds support for `before` as well as some tests to ensure it doesn't regress. I also added tests to the group's activity posts as well since those were missing. Finally I deleted some unused code (`group.messages_for`) which is not used anymore. Context - https://meta.discourse.org/t/-/308044/9
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/viewing-mentions-at-groups-activity-page-is-broken/308044/10 |
keegangeorge
approved these changes
May 17, 2024
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/daily-summary-5am-utc/291851/125 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 07ecbb5 we ensure the mentions in a group's activity page worked properly but we missed adding proper support for infinite loading.
The client is using the
beforeparameter instead of thebefore_post_idto do the pagination.This adds support for
beforeas well as some tests to ensure it doesn't regress.I also added tests to the group's activity posts as well since those were missing.
Finally I deleted some unused code (
group.messages_for) which is not used anymore.Context - https://meta.discourse.org/t/-/308044/9