DEV: Introduce @dedupeTracked
#27084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtaylorhq
force-pushed
the
dedupe-tracked
branch
from
7f322f3
to
623e273
Compare
Same as `@tracked`, but skips notifying consumers if the value is unchanged. This introduces some performance overhead, so should only be used where excessive downstream re-evaluations are a problem. This is loosely based on `@dedupeTracked` in the `tracked-toolbox` package, but without the added complexity of a customizable 'comparator'. Implementing ourselves also avoids the need for pulling in the entire package, which contains some tools which we don't want, or which are now implemented in Ember/Glimmer (e.g. `@cached`).
davidtaylorhq
force-pushed
the
dedupe-tracked
branch
from
623e273
to
2f397ab
Compare
CvX
reviewed
May 20, 2024
Comment on lines
27
to
31
| await render(<template> | ||
| <span id="initials">{{pet.initials}}</span> | ||
| </template>); | ||
|
|
||
| assert.dom("#initials").hasText("SD", "Initials are correct"); |
There was a problem hiding this comment.
is rendering a template necessary to this test? 😃
Suggested change
| await render(<template> | |
| <span id="initials">{{pet.initials}}</span> | |
| </template>); | |
| assert.dom("#initials").hasText("SD", "Initials are correct"); | |
| assert.strictEqual(pet.initials, "SD", "Initials are correct"); |
There was a problem hiding this comment.
Hmm... we need some way to know whether downstream autotracking is being notified of a change. Rendering is one way to do that. But perhaps we get the same effect by using @cached on the getter. Lemme try 👀
There was a problem hiding this comment.
Ok that's much cleaner with @cached. Thanks @CvX!
davidtaylorhq
force-pushed
the
dedupe-tracked
branch
from
8a412ec
to
81f6958
Compare
CvX
approved these changes
May 20, 2024
CvX
pushed a commit
that referenced
this pull request
May 21, 2024
Same as `@tracked`, but skips notifying consumers if the value is unchanged. This introduces some performance overhead, so should only be used where excessive downstream re-evaluations are a problem. This is loosely based on `@dedupeTracked` in the `tracked-toolbox` package, but without the added complexity of a customizable 'comparator'. Implementing ourselves also avoids the need for pulling in the entire package, which contains some tools which we don't want, or which are now implemented in Ember/Glimmer (e.g. `@cached`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as
@tracked, but skips notifying consumers if the value is unchanged. This introduces some performance overhead, so should only be used where excessive downstream re-evaluations are a problem.This is loosely based on
@dedupeTrackedin thetracked-toolboxpackage, but without the added complexity of a customizable 'comparator'. Implementing ourselves also avoids the need for pulling in the entire package, which contains some tools which we don't want, or which are now implemented in Ember/Glimmer (e.g.@cached).