DEV: Pull compatible themes in tests workflow #27093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
force-pushed
the
pull_compatible_theme_main
branch
from
fbfec8d
to
bd6f652
Compare
tgxworld
commented
May 21, 2024
Comment on lines
+239
to
+252
| # Checkout value of the version compat | ||
| if checkout_version | ||
| puts "checking out compatible #{theme_name} version: #{checkout_version}" | ||
|
|
||
| update_status = | ||
| system( | ||
| "git -C '#{theme_path}' cat-file -e #{checkout_version} || git -C '#{theme_path}' fetch --depth 1 $(git -C '#{theme_path}' rev-parse --symbolic-full-name @{upstream} | awk -F '/' '{print $3}') #{checkout_version}; git -C '#{theme_path}' reset --hard #{checkout_version}", | ||
| ) | ||
|
|
||
| abort("Unable to checkout a compatible theme version") unless update_status | ||
| else | ||
| puts "#{theme_name} is already at latest compatible version" | ||
| end | ||
| end |
There was a problem hiding this comment.
This is adapted from
discourse/lib/tasks/plugin.rake
Lines 156 to 168 in 1dcf756
This commit adds a step in our tests workflow on Github actions to update the themes to use the compatible version when not running aginast the `main` branch. This is to ensure that we are not running the tests for themes against an incompatible version of Discourse.
tgxworld
force-pushed
the
pull_compatible_theme_main
branch
from
bd6f652
to
e877642
Compare
martin-brennan
approved these changes
May 21, 2024
| .glob(File.expand_path("#{Rails.root}/tmp/themes/*")) | ||
| .select { |f| File.directory? f } | ||
| .each do |theme_path| | ||
| next unless File.directory?(theme_path + "/.git") |
There was a problem hiding this comment.
Suggested change
| next unless File.directory?(theme_path + "/.git") | |
| next if !File.directory?(theme_path + "/.git") |
:P
| "git -C '#{theme_path}' cat-file -e #{checkout_version} || git -C '#{theme_path}' fetch --depth 1 $(git -C '#{theme_path}' rev-parse --symbolic-full-name @{upstream} | awk -F '/' '{print $3}') #{checkout_version}; git -C '#{theme_path}' reset --hard #{checkout_version}", | ||
| ) | ||
|
|
||
| abort("Unable to checkout a compatible theme version") unless update_status |
There was a problem hiding this comment.
Suggested change
| abort("Unable to checkout a compatible theme version") unless update_status | |
| abort("Unable to checkout a compatible theme version") if !update_status |
|
Thank you @martin-brennan 👍 |
CvX
pushed a commit
that referenced
this pull request
May 21, 2024
This commit adds a step in our tests workflow on Github actions to update the themes to use the compatible version when not running aginast the `main` branch. This is to ensure that we are not running the tests for themes against an incompatible version of Discourse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a step in our tests workflow on Github actions to update the themes to
use the compatible version when not running aginast the
mainbranch.This is to ensure that we are not running
the tests for themes against an incompatible version of Discourse.