FIX: Importers should create duplicate categories if the parent category is different #3270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt category is different This changes the content of `@categories_lookup` from `Category` objects to IDs since the category names aren't needed anymore. The lookup method has been renamed too.
|
You've signed the CLA, gschlager. Thank you! This pull request is ready for review. |
|
Thanks for this fix! All the importers just got better. 👍 |
nlalonde
added a commit
that referenced
this pull request
Mar 12, 2015
FIX: Importers should create duplicate categories if the parent category is different
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://meta.discourse.org/t/phpbb-3-importer-goes-slow/26182/8?u=gerhard
This changes the content of
@categories_lookupin the base importer fromCategoryobjects to IDs since the category names aren't needed anymore. The lookup method has been renamed too.All importers (except askbot which seems to do this differently) were changed to use the category ID instead of name.