Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Dropdown not dismissing until next page renders. #3571

Merged

Conversation

tgxworld
Copy link
Contributor

@discoursebot
Copy link

You've signed the CLA, tgxworld. Thank you! This pull request is ready for review.

@tgxworld
Copy link
Contributor Author

One behavior that will change here is that when we search within a topic, clicking on any results will close the dropdown as opposed to the previous behavior where the search will remain open. Was the previous behavior by design?

@SamSaffron
Copy link
Member

yes, previous behavior was by design.

On Sat, Jun 27, 2015 at 1:31 AM, Guo Xiang Tan notifications@github.com
wrote:

One behavior that will change here is that when we search within a topic,
clicking on any results will close the dropdown as opposed to the previous
behavior where the search will remain open. Was the previous behavior by
design?


Reply to this email directly or view it on GitHub
#3571 (comment).

@tgxworld
Copy link
Contributor Author

@sam ok! I'll update the PR to take that into account.

@tgxworld tgxworld force-pushed the fix_header_not_dismissing_on_click branch from 49e7a84 to f444fd1 Compare June 29, 2015 08:03
@tgxworld tgxworld force-pushed the fix_header_not_dismissing_on_click branch from f444fd1 to 5c93188 Compare June 29, 2015 14:18
@tgxworld tgxworld changed the title FIX: Dropdown not dismissing until next page renders. UX: Dropdown not dismissing until next page renders. Jun 29, 2015
@SamSaffron
Copy link
Member

cool 👍

SamSaffron added a commit that referenced this pull request Jul 9, 2015
…lick

UX: Dropdown not dismissing until next page renders.
@SamSaffron SamSaffron merged commit 160ee67 into discourse:master Jul 9, 2015
@tgxworld tgxworld deleted the fix_header_not_dismissing_on_click branch September 15, 2015 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants