Allow +1 via email #3943
Merged
Allow +1 via email #3943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've signed the CLA, gdpelican. Thank you! This pull request is ready for review. |
| @@ -239,6 +244,18 @@ def wrap_body_in_quote(user_email) | |||
| @body = "[quote=\"#{user_email}\"]\n#{@body}\n[/quote]" | |||
| end | |||
|
|
|||
| def create_post_action(email_log, type) | |||
| PostAction.act(email_log.user, email_log.post, type) | |||
There was a problem hiding this comment.
Calling act doesn't seem to ensure the guardian calls are executed.
You'll need to make sure something like this code is executed.
(you'll also need a test for this -- what happens when the guardian check fails?)
There was a problem hiding this comment.
Alright, I've applied a guardian call to the create_post_action and added a few specs around it; should be good for another look @eviltrout
|
Fantastic work, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy to hear some feedback on this one.