Use sRGB Color Profile when converting images #4064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the conversion done when uploading or fetching an image we also lose any embedded color profiles. [This leads to images possibly not rendered properly in the browsers.][1] To fix the issue we tell imagemagick to render the image from the embedded color profile to sRGB, which is the color space used by most browsers. RT_sRGB.icm is taken from the [RawTherapee repository][2] and is licensed as Public Domain. [1]: https://meta.discourse.org/t/image-embedded-color-profile/40519 [2]: https://github.com/Beep6581/RawTherapee/blob/master/rtdata/iccprofiles/output/RT_sRGB.icm
|
You've signed the CLA, darix. Thank you! This pull request is ready for review. |
|
👍 looks good, but how risky is this change? It is referencing a local file, will that file be present? @ZogStriP ? |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
How is that different from using the |
|
@ZogStriP the |
|
If:
|
ZogStriP
added a commit
that referenced
this pull request
Mar 8, 2016
Use sRGB Color Profile when converting images
|
Let's try it. 👍 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the conversion done when uploading or fetching an image we also
lose any embedded color profiles. This leads to images possibly not rendered
properly in the browsers. To fix the issue we tell imagemagick to render
the image from the embedded color profile to sRGB, which is the color
space used by most browsers.
RT_sRGB.icm is taken from the RawTherapee repository and is licensed as Public Domain.