Fixed anonymizer when 'full name required' setting is on #4087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the setting 'full name required' is on the anonymizer was trying to set the user name to nil and this caused the user name and email to remain not anonymized. Now in this scenario the user name is set to the anonimized username and the email is anonymized correctly.
|
You've signed the CLA, jeremylan. Thank you! This pull request is ready for review. |
|
I like this, but could you add a test to ensure we don't regress here? |
|
Sure @ZogStriP, I'll do that. Do you have any links to commits with tests? That would help me as this is my first pull request! |
|
I don't have a link to commits with tests, but you can look at https://github.com/discourse/discourse/blob/master/spec/services/user_anonymizer_spec.rb. This might help get you started ;) Also, don't hesitate to ask if you have any questions. |
Added context and new test to check for correct user anonymizing depending on full_name_required Site Setting
|
Thanks @ZogStriP, I've updated the test using context, hope it's ok. |
|
thanks |
SamSaffron
added a commit
that referenced
this pull request
Mar 18, 2016
Fixed anonymizer when 'full name required' setting is on
|
also added this, c2fa314 cause tests were not covering this correctly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the setting 'full name required' is on the anonymizer was trying to set the user name to nil and this caused the user name and email to remain not anonymized.
Now in this scenario the user name is set to the anonymized username and the email is anonymized correctly.