Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Advanced Search to utilize Category Selector so it can distingui… #4527

Merged
merged 1 commit into from Nov 3, 2016

Conversation

cpradio
Copy link
Contributor

@cpradio cpradio commented Oct 31, 2016

…sh uncategorized from no category selected

@mention-bot
Copy link

@cpradio, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tgxworld and @eviltrout to be potential reviewers.

@discoursebot
Copy link

You've signed the CLA, cpradio. Thank you! This pull request is ready for review.

@cpradio
Copy link
Contributor Author

cpradio commented Oct 31, 2016

@tgxworld, you will notice, I changed searchedTerms.category to '' instead of null, as you can see, username does that too, it seems autocomplete likes empty string over null, otherwise, it kicks all sorts of errors and I didn't want to mess with the category selector too much in fear of breaking other usages.

@cpradio
Copy link
Contributor Author

cpradio commented Oct 31, 2016

Should the Time Out be increased for qunit's rake task? I feel like all of my checkins keep hitting it.

@tgxworld tgxworld closed this Nov 2, 2016
@tgxworld tgxworld reopened this Nov 2, 2016
@discoursebot
Copy link

You've signed the CLA, cpradio. Thank you! This pull request is ready for review.

@cpradio
Copy link
Contributor Author

cpradio commented Nov 2, 2016

Ah, is that a way to trick it to re-run the tests? I've been wondering how that can be done 👍

@tgxworld
Copy link
Contributor

tgxworld commented Nov 2, 2016

Yup :)

@tgxworld
Copy link
Contributor

tgxworld commented Nov 3, 2016

@cpradio Looks good to me 👍 Thank you for the work 😄

@tgxworld tgxworld merged commit 847eea8 into discourse:master Nov 3, 2016
@cpradio cpradio deleted the category-selector branch November 3, 2016 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants