FEATURE: bulk relist #4860
Merged
FEATURE: bulk relist #4860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing this pull request! Could you please sign our CLA so we can review it? http://www.discourse.org/cla |
|
Do I need to fill the form every time I submit a PR? |
|
Your cla email must match your github email for it to "know" you
…On Tue, May 9, 2017 at 11:04 PM OsamaSayegh ***@***.***> wrote:
Do I need to fill the form every time I submit a PR?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4860 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABc7Ve0IEvrsYz0Zw0NW5f3ibm-_t9Fuks5r4VN2gaJpZM4NWMsj>
.
|
eviltrout
reviewed
May 10, 2017
| } | ||
| if (showRelistButton && !_buttons[9]) { | ||
| addBulkButton('relistTopics', 'relist_topics'); | ||
| } else if (!showRelistButton && _buttons[9]) { |
There was a problem hiding this comment.
Hard coding an index here seems dangerous. What is the condition actually checking? Is it if the button already exists? In that case it should be checking by some kind of indentifier.
eviltrout
reviewed
May 10, 2017
| @@ -26,6 +26,19 @@ export default Ember.Controller.extend(ModalFunctionality, { | |||
| categoryId: Ember.computed.alias('model.category.id'), | |||
|
|
|||
| onShow() { | |||
| let showRelistButton = false; | |||
| const topics = this.get('model.topics'); | |||
| for (let t = 0; t < topics.length; t++) { | |||
There was a problem hiding this comment.
I think this could be replaced by something like
const showRelistButton = this.get('model.topics').some(t => !t.visible)
|
@eviltrout Thanks for your feedback! would you mind taking another look? I've just made some changes :) |
|
Seems good now, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://meta.discourse.org/t/make-listed-again-in-the-bulk-actions/58286/5
I hope I did it right :)