Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX: Use user locale for locations. #6527

Merged
merged 2 commits into from
Oct 25, 2018
Merged

UX: Use user locale for locations. #6527

merged 2 commits into from
Oct 25, 2018

Conversation

nbianca
Copy link
Member

@nbianca nbianca commented Oct 24, 2018

No description provided.

@discoursebot
Copy link

You've signed the CLA, nbianca. Thank you! This pull request is ready for review.

@ZogStriP
Copy link
Member

Looks good 👍 Can you add a test as well?

@gschlager
Copy link
Member

Looks good, but you might need to replace _ in locale names with -. It looks like MaxMind uses a different format for locales:

MaxMind Discourse
de de
en en
es es
fr fr
ja ja
pt-BR pt_BR
ru ru
zh-CN zh_CN

@nbianca nbianca force-pushed the ip_locale branch 2 times, most recently from 60283b6 to 9ccf2fc Compare October 24, 2018 17:36
@SamSaffron
Copy link
Member

looks good to me.

@gschlager
Copy link
Member

Rubocop isn't happy @nbianca 😉
https://travis-ci.org/discourse/discourse/jobs/446056582

@ZogStriP ZogStriP merged commit effbef7 into discourse:master Oct 25, 2018
@nbianca nbianca deleted the ip_locale branch February 22, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZogStriP ZogStriP ZogStriP approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
5 participants
@nbianca @discoursebot @ZogStriP @gschlager @SamSaffron