FIX: Relative links in translations should work with subfolder #6574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've signed the CLA, gschlager. Thank you! This pull request is ready for review. |
gschlager
commented
Nov 7, 2018
| @@ -41,7 +41,7 @@ export default Ember.Component.extend({ | |||
| classNameBindings: ["isEnabled", "isLoading", "dasherizedDataSourceName"], | |||
| classNames: ["admin-report"], | |||
| isEnabled: true, | |||
| disabledLabel: "admin.dashboard.disabled", | |||
| disabledLabel: I18n.t("admin.dashboard.disabled"), | |||
There was a problem hiding this comment.
@jjaffeux I had to change disabledLabel from being an I18n key to the actual translated string. I hope that doesn't create any problems.
Generated by 🚫 Danger |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/broken-links-in-subfolder-installs/100355/11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates translations which contain relative links (HTML and Markdown) so that they work with subfolders. It adds specs to prevent us from adding new translations with the same problem.
This supersedes #6510 which has been reverted.
Do not merge yet. I need to fix translations in a couple of plugins and to work on pushing fixed translations to Transifex, otherwise this commit will invalidate some important translations like
read_more_MFandguidelines_topic.