FEATURE: Scroll-based logo on mobile #6632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a few places where I skipped `this.get('foo')` and used `this.foo` because faster is better and it seems to be working without issue when I tested.
The order here was incorrect, the order we want is: 1- logo 2- header topic info 3- user panels
This commit adds a height attribute to the large logo since that eliminates the need for a number of CSS rules to control its dimensions. The height and width are set for the small logo but only the height is set for the large logo. We set its width with one small CSS rule
some of these are moved to the header stylesheet
some of these are moved to the header stylesheet
This is now moved to the header stylesheet
hnb-ku
changed the title
awesomerobot
requested changes
Nov 20, 2018
app/assets/javascripts/discourse/components/discourse-topic.js.es6
Outdated
Show resolved
Hide resolved
|
This is working as expected in Chrome, but tags aren't truncating in Safari... I recall running into this before but don't remember the solution. I'm going to look into this again a bit later and I'll let you know if I can figure it out.
|
|
Ah, found it — if you add |
awesomerobot
approved these changes
Nov 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to show the small logo and topic information in the header on mobile while the user is scrolling down.
Previous related discussions can be found here https://meta.discourse.org/t/smart-mobile-header/99846
Re-ordering the elements in the header-contents widget came up while working on this. So, this PR also re-orders those elements and converts the header to flexbox