Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: ensures topic’s category allows topics tags #7060

Merged
merged 4 commits into from Feb 26, 2019
Merged

FIX: ensures topic’s category allows topics tags #7060

merged 4 commits into from Feb 26, 2019

Conversation

jjaffeux
Copy link
Contributor

No description provided.

@discoursebot
Copy link

You've signed the CLA, jjaffeux. Thank you! This pull request is ready for review.

@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/category-allowed-tags-do-not-reload-with-category-change/95406/30

eviltrout
eviltrout reviewed Feb 25, 2019
View reviewed changes
app/controllers/topics_controller.rb Outdated Show resolved Hide resolved
spec/requests/topics_controller_spec.rb Show resolved Hide resolved
spec/requests/topics_controller_spec.rb Outdated Show resolved Hide resolved
ZogStriP and others added 2 commits February 26, 2019 10:36
@ZogStriP @jjaffeux
Update app/controllers/topics_controller.rb
5eb30ca 
Co-Authored-By: jjaffeux <j.jaffeux@gmail.com>
@ZogStriP @jjaffeux
Update app/controllers/topics_controller.rb
2a5f871 
Co-Authored-By: jjaffeux <j.jaffeux@gmail.com>
@discoursedangerbot
Copy link

1 Error
🚫

This PR doesn’t match our required code formatting standards, as enforced by prettier.io. Here’s how to set up prettier in your code editor.

app/assets/javascripts/discourse/controllers/preferences/account.js.es6

Generated by 🚫 Danger

@jjaffeux jjaffeux merged commit 7ccb0b8 into discourse:master Feb 26, 2019
@jjaffeux jjaffeux deleted the category-tag-validation branch February 26, 2019 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eviltrout eviltrout eviltrout approved these changes

@ZogStriP ZogStriP ZogStriP approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
5 participants
@jjaffeux @discoursebot @discoursedangerbot @eviltrout @ZogStriP