New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Skip small actions when counting replies in PMs. #7108
Conversation
You've signed the CLA, udan11. Thank you! This pull request is ready for review. |
app/models/topic.rb
Outdated
@@ -527,7 +527,7 @@ def update_status(status, enabled, user, opts = {}) | |||
end | |||
|
|||
# Atomically creates the next post number | |||
def self.next_post_number(topic_id, reply = false, whisper = false) | |||
def self.next_post_number(topic_id, reply = false, whisper = false, post = true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 is a crowd. Can you change these optional parameters to named ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Topic.next_post_number
has now too many optional parameters.
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/waiting-for-reply-state-for-group-messages/50382/5 |
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/reply-count-on-blog-comments-off-by-one/188402/1 |
No description provided.