FIX: Clear unsaved groups when switching user #7236
Conversation
|
You've signed the CLA, venarius. Thank you! This pull request is ready for review. |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/admin-user-group-membership-edition-persists-between-users/112239/2 |
|
Unfortunately we will rarely accept a fix without a test. If you need some clues on how to add a test @jjaffeux can probably help you out. |
Fixing a bug or a regression is a very good reason to add/fix a test 😉 |
|
cc @ZogStriP @eviltrout took me quite some time but I got it figured out 🙂 |
| @@ -19,6 +19,7 @@ export default Discourse.Route.extend({ | |||
| controller.setProperties({ | |||
| originalPrimaryGroupId: model.get("primary_group_id"), | |||
| availableGroups: this._availableGroups, | |||
| customGroupIdsBuffer: null, | |||
There was a problem hiding this comment.
I wonder, are these properties the only ones we need to reset?
There was a problem hiding this comment.
I will have a look at it and check if there are more things that need to be reset 👍
There was a problem hiding this comment.
@ZogStriP I tried a lot of things but all other user settings seem fine to me
This clears unsaved groups when admin switches to another user without saving.
Resolves: https://meta.discourse.org/t/admin-user-group-membership-edition-persists-between-users/112239
Didn't write a test for it since I didn't find any acceptance tests for custom groups. Just tell me when I should write some.