Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: frozen string exception #7505

Merged
merged 2 commits into from May 8, 2019
Merged

FIX: frozen string exception #7505

merged 2 commits into from May 8, 2019

Conversation

jjaffeux
Copy link
Contributor

@jjaffeux jjaffeux commented May 8, 2019

Initial backtrace:

/var/www/discourse/app/mailers/user_notifications.rb:554:in `send_notification_email'
/var/www/discourse/app/mailers/user_notifications.rb:459:in `notification_email'
/var/www/discourse/app/mailers/user_notifications.rb:318:in `user_private_message'

@jjaffeux
FIX: frozen string exception
904b909 
Intial backtrace:

```
/var/www/discourse/app/mailers/user_notifications.rb:554:in `send_notification_email'
/var/www/discourse/app/mailers/user_notifications.rb:459:in `notification_email'
/var/www/discourse/app/mailers/user_notifications.rb:318:in `user_private_message'
```
@jjaffeux
this might fail too
4689127
@discoursebot
Copy link

You've signed the CLA, jjaffeux. Thank you! This pull request is ready for review.

@jjaffeux jjaffeux requested a review from tgxworld May 8, 2019 09:43
@jjaffeux jjaffeux merged commit 2938e3f into discourse:master May 8, 2019
@jjaffeux jjaffeux deleted the frozen-1 branch May 8, 2019 14:52
jjaffeux added a commit that referenced this pull request May 8, 2019
@jjaffeux
Revert "FIX: frozen string exception (#7505)"
497c0ba 
This reverts commit 2938e3f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgxworld tgxworld Awaiting requested review from tgxworld

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@jjaffeux @discoursebot