Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use yajl-ruby for json encoding #771

Closed
wants to merge 1 commit into from
Closed

Conversation

jroes
Copy link
Contributor

@jroes jroes commented Apr 25, 2013

Implemented recommendation based on TODO found in the original source.

@discoursebot
Copy link

Thanks for contributing this pull request! Could you please sign our CLA so we can review it? http://www.discourse.org/cla

@jroes
Copy link
Contributor Author

jroes commented Apr 25, 2013

Signed.

@SamSaffron
Copy link
Member

hmmm ... we already have oj, @nlalonde is there a reason you wanted yajl, oj is faster anyway and we already have a gazzilion gems

@nlalonde
Copy link
Member

At the time, I found some benchmarks that claimed that yajl was faster for json encoding, but I didn't try it or benchmark it myself. If oj is faster, then we can just stick with that.

@jroes jroes mentioned this pull request Apr 27, 2013
@jroes
Copy link
Contributor Author

jroes commented Apr 27, 2013

Closing in favor of #776 / Use oj for json encoding.

@jroes jroes closed this Apr 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants