Redis 4 1 3 #8204
Merged
Redis 4 1 3 #8204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I run our benchmark on commit with hiredis and redis-4.1.3 Results: type | hidredis | redis 4.1.3 | percent --- | --- | --- | --- Categories-50 | 49 | 50 | 102.04% Categories-75 | 51 | 51 | 100.00% Categories-90 | 63 | 64 | 101.59% Categories-99 | 86 | 85 | 98.84% Home-50 | 55 | 55 | 100.00% Home-75 | 56 | 57 | 101.79% Home-90 | 68 | 69 | 101.47% Home-99 | 102 | 104 | 101.96% Topic-50 | 36 | 37 | 102.78% Topic-75 | 37 | 37 | 100.00% Topic-90 | 47 | 48 | 102.13% Topic-99 | 60 | 61 | 101.67% Categories-admin-50 | 124 | 117 | 94.35% Categories-admin-75 | 130 | 129 | 99.23% Categories-admin-90 | 147 | 143 | 97.28% Categories-admin-99 | 204 | 199 | 97.55% Home-admin-50 | 146 | 148 | 101.37% Home-admin-75 | 150 | 152 | 101.33% Home-admin-90 | 169 | 168 | 99.41% Home-admin-99 | 232 | 223 | 96.12% Topic-admin-50 | 60 | 61 | 101.67% Topic-admin-75 | 64 | 63 | 98.44% Topic-admin-90 | 76 | 73 | 96.05% Topic-admin-99 | 124 | 94 | 75.81% Load rails | 2412 | 2360 | 97.84% rss | 290204 | 295828 | 101.94% pss | 277948 | 283624 | 102.04%
|
You've signed the CLA, lis2. Thank you! This pull request is ready for review. |
|
You've signed the CLA, lis2. Thank you! This pull request is ready for review. |
Redis gem is manipulating Redis config https://github.com/redis/redis-rb/blob/master/lib/redis/client.rb#L95 therefore we cannot pass the frozen config object. Pass of the copy of the object is protecting original config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem is that the original Redis gem is removing :connector option (https://github.com/redis/redis-rb/blob/master/lib/redis/client.rb#L95)
We are passing that options around between retries and removing that on our end.
I created a PR for MessageBus to fix that problem (https://github.com/SamSaffron/message_bus/pull/214/files) and for now we need freedom_patch
I checked on my local machine that with new freedom patch it is still working.
Testing steps.
DiscourseRedis::FallbackHandler: Checking connection to master server...DiscourseRedis::FallbackHandler: Master server is active, killing all connections to slave...