FIX: Mobile topic-timeline not closing on scrolling past last post #8730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* when we dragged the topic-timeline handle past the last post in a topic we were not closing the timeline as we would if scrolling to a specific post * this also fixes the issue where when scrolling past the end of the topic with a massive last post, none of the post could be seen
|
You've signed the CLA, martin-brennan. Thank you! This pull request is ready for review. |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/post-excerpts-are-missing-from-the-expanded-mobile-timeline/132768/9 |
|
lets give this a shot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://meta.discourse.org/t/post-excerpts-are-missing-from-the-expanded-mobile-timeline/132768/4.
in a topic we were not closing the timeline as we would if
scrolling to a specific post
the topic with a massive last post, none of the post could be
seen