Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes to support posts with no user #8877

Merged
merged 7 commits into from Mar 11, 2020
Merged

Various fixes to support posts with no user #8877

merged 7 commits into from Mar 11, 2020

Conversation

udan11
Copy link
Contributor

@udan11 udan11 commented Feb 6, 2020

No description provided.

@discoursebot
Copy link

You've signed the CLA, udan11. Thank you! This pull request is ready for review.

@udan11 udan11 requested a review from ZogStriP February 10, 2020 10:21
@udan11 udan11 marked this pull request as ready for review February 10, 2020 10:21
eviltrout
eviltrout approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@eviltrout eviltrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to merge. Overall looks like it adds a fair bit of safety.

@eviltrout
Copy link
Contributor

@udan11 please merge when you are around to see through any bugs, perhaps the beginning of a day.

@udan11 udan11 merged commit 0754c7c into discourse:master Mar 11, 2020
@udan11 udan11 deleted the fix_posts_without_user branch March 15, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZogStriP ZogStriP ZogStriP left review comments

@eviltrout eviltrout eviltrout approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@udan11 @discoursebot @eviltrout @ZogStriP