Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Make inline oneboxes work with secured topics in secured contexts #8895

Merged
merged 2 commits into from Feb 12, 2020
Merged

FIX: Make inline oneboxes work with secured topics in secured contexts #8895

merged 2 commits into from Feb 12, 2020

Conversation

udan11
Copy link
Contributor

@udan11 udan11 commented Feb 7, 2020

No description provided.

@discoursebot
Copy link

You've signed the CLA, udan11. Thank you! This pull request is ready for review.

@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/private-topic-links-are-not-displayed-as-topic-titles/140952/11

@udan11 udan11 requested a review from ZogStriP February 10, 2020 10:53
eviltrout
eviltrout reviewed Feb 10, 2020
View reviewed changes
Copy link
Contributor

@eviltrout eviltrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a test that ensures the private category logic? I don't see one here but maybe it exists already.

In other words, I'd like to see a onebox fail if the category is different and private, even if the user posting can see it.

@udan11
Copy link
Contributor Author

udan11 commented Feb 11, 2020

That behaviour is already tested in oneboxer_spec.rb, but I have added another test in inline_oneboxer_spec.rb.

@udan11 udan11 requested a review from ZogStriP February 12, 2020 09:47
@udan11 udan11 merged commit ec40242 into discourse:master Feb 12, 2020
@udan11 udan11 deleted the fix_inline_onebox branch February 14, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eviltrout eviltrout eviltrout left review comments

@ZogStriP ZogStriP ZogStriP approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@udan11 @discoursebot @eviltrout @ZogStriP