FIX: Subfolder sites rewriting URLs to root domain on initial load #8932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DiscourseLocation.initState function was renamed in 0431942 (select-kit-2) to initOptions. This means that the ember router does not automatically call the function after the router is initialized. For a long time, we have been calling the initState function in the init() function of discourse-location, which caused an imperceptible URL change to the the root domain, before switching back to the correct subfolder URL when ember called initState. This commit removes that call from the initializer, so initState is only called once (by ember). Relevant ember code: https://github.com/emberjs/ember.js/blob/v3.12.2/packages/@ember/-internals/routing/lib/system/router.ts#L695-L699
|
You've signed the CLA, davidtaylorhq. Thank you! This pull request is ready for review. |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/recent-changes-breaking-subfolder-setup/141232/15 |
jjaffeux
reviewed
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DiscourseLocation.initState function was renamed in 0431942 (select-kit-2) to
initOptions. This means that the ember router does not automatically call the function after the router is initialized.For a long time, we have been calling the initState function in the init() function of discourse-location, which caused an imperceptible URL change to the the root domain, before switching back to the correct subfolder URL when ember called initState. This commit removes that call from the initializer, so initState is only called once (by ember).
Relevant ember code: https://github.com/emberjs/ember.js/blob/v3.12.2/packages/@ember/-internals/routing/lib/system/router.ts#L695-L699
Context at https://meta.discourse.org/t/recent-changes-breaking-subfolder-setup/141232