More refactoring #898
Merged
More refactoring #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeclimate pointed this out. I agree it is better to simplify and reveal intentions.
|
You've signed the CLA, mattvanhorn. Thank you! This pull request is ready for review. |
|
In that case everything looks good. Since it touches a lot of files I'm not comfortable merging on a Friday evening, but I'd like to get it in early next week. |
|
Understood. |
Switched the algorithm to use a circular buffer based on a redis list
|
Merged in, thanks! I did it manually due to a conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of Topic, RateLimiter, TextSentinel
extracted new TopicNotifier class
added pry-nav gem and made pry available in test as well as dev