FIX: Show topic level bookmark with reminder modal #9336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
martin-brennan
commented
Apr 2, 2020
•
martin-brennan
commented
- When using the topic-level bookmark button or shortcut, we now show the bookmark with reminder modal for consistency.
- When hovering on a bookmark reminder notification where the bookmark has a name, show the name of the bookmark on hover.
* this is so users get the same functionality bookmarking a topic (which bookmarks the first post) as they would when bookmarking the post itself
jjaffeux
reviewed
Apr 2, 2020
|
|
||
| // make sure the input is cleared, otherwise the keyboard shortcut to toggle | ||
| // bookmark for post ends up in the input | ||
| setTimeout(() => this.set("name", null)); |
There was a problem hiding this comment.
Same remark as on the other PR: never setTimeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.