Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Set user timezone on password reset login #9461

Merged
merged 1 commit into from Apr 17, 2020
Merged

FIX: Set user timezone on password reset login #9461

merged 1 commit into from Apr 17, 2020

Conversation

markvanlan
Copy link
Contributor

No description provided.

@eviltrout
Copy link
Contributor

Can you provide some context for this change please?

@markvanlan
Copy link
Contributor Author

Can you provide some context for this change please?

When a new clicks an invite link, it takes them to the password reset page to set their first password.

They are then logged in. That user's timezone was not set in the process, but while logging in normally, the timezone is set. This follows the same pattern, as it sets the user timezone when they log in, if the timezone was previously unset.

eviltrout
eviltrout approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@eviltrout eviltrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Remember context is always good for future people who review code and want to understand it.

@markvanlan markvanlan merged commit 0e74dd7 into discourse:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eviltrout eviltrout eviltrout approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@markvanlan @eviltrout