Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: Deprecate Category#url_with_id in favor of Category#url #9972

Merged
merged 2 commits into from Jun 18, 2020
Merged

DEV: Deprecate Category#url_with_id in favor of Category#url #9972

merged 2 commits into from Jun 18, 2020

Conversation

udan11
Copy link
Contributor

@udan11 udan11 commented Jun 3, 2020 •
edited

I checked the plugins in all-the-plugins repo and they should be compatible with the change.

@udan11 udan11 marked this pull request as ready for review June 10, 2020 14:58
@udan11 udan11 requested a review from ZogStriP June 11, 2020 15:32
ZogStriP
ZogStriP reviewed Jun 11, 2020
View reviewed changes
app/models/permalink.rb Outdated Show resolved Hide resolved
@udan11 @ZogStriP
Update app/models/permalink.rb
2948445 
Co-authored-by: Régis Hanol <regis@hanol.fr>
@udan11 udan11 merged commit d21a08c into discourse:master Jun 18, 2020
@udan11 udan11 deleted the dev/category_url branch June 18, 2020 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZogStriP ZogStriP ZogStriP approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@udan11 @ZogStriP