Skip to content

Commit

Permalink
DEV: Resolve deprecations in upgrade-notice component (#162)
Browse files Browse the repository at this point in the history
  • Loading branch information
@davidtaylorhq
davidtaylorhq committed Dec 22, 2022
1 parent e9f53db commit 98205ea
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
10 changes: 10 additions & 0 deletions assets/javascripts/discourse/components/upgrade-notice.js
View file
@@ -0,0 +1,10 @@
import getURL from "discourse-common/lib/get-url";
import Component from "@ember/component";

export default class extends Component {
tagName = "tr";

get href() {
return getURL("/admin/upgrade");
}
}
9 changes: 0 additions & 9 deletions assets/javascripts/discourse/components/upgrade-notice.js.es6
View file

This file was deleted.

6 comments on commit 98205ea

@mentalstring
Copy link

@mentalstring mentalstring commented on 98205ea Jan 6, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidtaylorhq Not sure if this commit is the cause, but after upgrading docker_manager on a latest stable, the Perform upgrades here. link on the admin dashboard no longer works (going directly to /admin/upgrade works though).

@davidtaylorhq
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the report @mentalstring - I think this should be fixed by #164

@sbrighiu
Copy link

@sbrighiu sbrighiu commented on 98205ea Feb 5, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took so much time to find this and fix it :)
Latest version is currently bricking every rebuild that I do :)

Error:
MiniRacer::RuntimeError: SyntaxError: javascripts/discourse/components/upgrade-notice: Unexpected token (5:10)

Resolve (replace in app.yml when installing docker_manager):

@davidtaylorhq
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbrighiu what version of Discourse were you upgrading from?

@discoursereviewbot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sbrighiu posted:

i’m using a very old version - 2.5.0.beta7
I think it’s because of the ruby version bump.
In my cases I ended up removing the plugin as I was not really using it.

Stefan M. Brighiu
Engineering Manager @ Atta Systems
Phone: +40 744 581 921
Web: https://atta.systems

@sbrighiu
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not upgrading, I was simply rebuilding the app and upon rebuild i clone the latest version available in github

Please sign in to comment.