DEV: rename the "upgrade" route to "update" and change references. #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janzenisaac
reviewed
Apr 2, 2024
config/routes.rb
Outdated
Comment on lines
14
to
15
| post "/docker/update" => "admin#update" | ||
| delete "/docker/update" => "admin#reset_update" |
There was a problem hiding this comment.
I don't see updates to the controller actions, do we need to do that as well?
There was a problem hiding this comment.
Good catch! I now reverted the changes in route methods. I'm not going rename the method names in this PR (only the routes).
janzenisaac
reviewed
Apr 3, 2024
lib/docker_manager/upgrader.rb
Outdated
| @@ -257,9 +257,9 @@ def status(val) | |||
| publish("status", val) | |||
| end | |||
|
|
|||
| def log_version_upgrade | |||
| def log_version_update | |||
There was a problem hiding this comment.
We renamed the method, but I don’t see another instance of the method in the list of changes. Do we have more places to update?
There was a problem hiding this comment.
I didn't intent to update that method name too. I fixed it now. I doubled checked all other method names again.
janzenisaac
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will rename the route "
/admin/upgrade" to "/admin/update" and it will add a redirect for the old route.Follow-up to the PR: #208