Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config required to support .gjs (<template> tag) #34

Merged
merged 1 commit into from Jun 21, 2023
Merged

Add config required to support .gjs (<template> tag) #34

merged 1 commit into from Jun 21, 2023

Conversation

chancancode
Copy link
Contributor

See the comments and the linked issues for additional context.

I arbitrarily decided to put the template tag at the top of the class but happy to change that to whatever seems reasonable.

ember-cli/eslint-plugin-ember#1895
ember-cli/eslint-plugin-ember#1896

@chancancode
Add config required to support .gjs (<template> tag)
e516bfb 
See the comments and the linked issues for additional context.

I arbitrarily decided to put the template tag at the top of the
class but happy to change that to whatever seems reasonable.

ember-cli/eslint-plugin-ember#1895
ember-cli/eslint-plugin-ember#1896
@chancancode
Copy link
Contributor Author

cc @davidtaylorhq @CvX

CvX
CvX approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@CvX CvX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@CvX CvX merged commit 543fccb into discourse:main Jun 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CvX CvX CvX approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@chancancode @CvX