Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Add inline grouping pattern creation #219

Merged
merged 9 commits into from
Jan 22, 2024
Merged

FEATURE: Add inline grouping pattern creation #219

merged 9 commits into from
Jan 22, 2024

Conversation

janzenisaac
Copy link
Contributor

@janzenisaac janzenisaac commented Jan 18, 2024 •
edited

test.mov

Updated Styling

update-beh.mov

pmusaraj
pmusaraj reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@pmusaraj pmusaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice work!

I would approve it, but as discussed in chat, you're going to make a bit of UI fine-tuning first.

client-app/app/controllers/index.js Outdated Show resolved Hide resolved
client-app/tests/unit/controllers/index-test.js Show resolved Hide resolved
client-app/app/templates/index.hbs Outdated Show resolved Hide resolved
pmusaraj
pmusaraj approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@pmusaraj pmusaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Only thing left is to bump up the version to 2.16.0.

@janzenisaac janzenisaac merged commit b726b74 into main Jan 22, 2024
7 checks passed
@janzenisaac janzenisaac deleted the add-inline-grouping-pattern branch January 22, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CvX CvX CvX left review comments

@davidtaylorhq davidtaylorhq davidtaylorhq left review comments

@pmusaraj pmusaraj pmusaraj approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@janzenisaac @CvX @pmusaraj @davidtaylorhq