Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gfycat handler #285

Merged
merged 1 commit into from Mar 26, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 19 additions & 1 deletion lib/onebox/engine/standard_embed.rb
Expand Up @@ -6,13 +6,24 @@ def self.oembed_providers
@@oembed_providers ||= {}
end

def self.opengraph_providers
@@opengraph_providers ||= Array.new
end

def self.add_oembed_provider(regexp, endpoint)
oembed_providers[regexp] = endpoint
end

def self.add_opengraph_provider(regexp)
opengraph_providers.push(regexp)
end

# Some oembed providers (like meetup.com) don't provide links to themselves
add_oembed_provider /www\.meetup\.com\//, 'http://api.meetup.com/oembed'

# Sites that work better with OpenGraph
add_opengraph_provider /gfycat\.com\//

def raw
return @raw if @raw

Expand All @@ -26,7 +37,14 @@ def raw
response = Onebox::Helpers.fetch_response(url)
html_doc = Nokogiri::HTML(response.body)

# Determine if we should use OEmbed or OpenGraph
StandardEmbed.opengraph_providers.each do |regexp|
if url =~ regexp
@raw = parse_open_graph(html_doc, url)
return @raw if @raw
end
end

# Determine if we should use oEmbed or OpenGraph (prefers oEmbed)
oembed_alternate = html_doc.at("//link[@type='application/json+oembed']") || html_doc.at("//link[@type='text/json+oembed']")
fetch_oembed_raw(oembed_alternate)

Expand Down
1 change: 1 addition & 0 deletions lib/onebox/engine/whitelisted_generic_onebox.rb
Expand Up @@ -54,6 +54,7 @@ def self.default_whitelist
forbes.com
foxnews.com
funnyordie.com
gfycat.com
groupon.com
howtogeek.com
huffingtonpost.com
Expand Down