Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Small Amazon fixes #463

Merged
merged 7 commits into from Apr 2, 2021
Merged

DEV: Small Amazon fixes #463

merged 7 commits into from Apr 2, 2021

Conversation

jbrw
Copy link
Contributor

@jbrw jbrw commented Mar 31, 2021

  • Use the canonical URL as the link within the generated onebox

  • Use the data-old-hires value for the image URL, if available

  • Version bump to 2.2.10

* Use the canonical URL as the link within the generated onebox

* Use the `data-old-hires` value for the image URL, if available

* Version bump to 2.2.10
@jbrw jbrw marked this pull request as draft March 31, 2021 23:55
@jbrw
Copy link
Contributor Author

jbrw commented Mar 31, 2021

Note to self: I need to make sure this doesn't interfere with the operation of the https://github.com/discourse/discourse-affiliate plugin

lib/onebox/engine/amazon_onebox.rb Show resolved Hide resolved
lib/onebox/engine/amazon_onebox.rb Outdated Show resolved Hide resolved
@jbrw jbrw marked this pull request as ready for review April 1, 2021 19:13
@jbrw jbrw requested a review from CvX April 1, 2021 19:13
lib/onebox/engine/amazon_onebox.rb Outdated Show resolved Hide resolved
lib/onebox/engine/amazon_onebox.rb Outdated Show resolved Hide resolved
lib/onebox/engine/amazon_onebox.rb Outdated Show resolved Hide resolved
lib/onebox/engine/html.rb Outdated Show resolved Hide resolved
jbrw and others added 2 commits April 2, 2021 14:25
@jbrw jbrw requested a review from CvX April 2, 2021 18:34
@jbrw jbrw merged commit d84e820 into master Apr 2, 2021
@jbrw jbrw deleted the small-amazon-fixes branch April 2, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants