FIX: ThreadError Handling #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good to me, a tiny bit fragile in case Ruby change the text on the exception but I guess that is the best we can do here. |
jobeus
pushed a commit
to scriptdash/prometheus_exporter
that referenced
this pull request
Dec 16, 2021
Don't leak out an exception if the main thread is killed. ``` if (GET_VM()->main_thread->status == THREAD_KILLED) rb_raise(rb_eThreadError, "can't alloc thread"); ``` This can happen during certain application shutdowns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @SamSaffron
We observed ThreadError was raised from prometheus_exporter when sidekiq triggers SHUTDOWN EXCEPTION.It was due to some improper shutdowns.
As per ruby ThreadError will raise only when main thread is killed then we are trying to create child thread for that main thread
So need to catch exception in Prometheus gem to handle this error.
Ref. PR: (opentelemetry-ruby) open-telemetry/opentelemetry-ruby#607