Commits on Sep 29, 2023

1. Get controller labels from controller, not params …

   prometheus_exporter currently reads the controller and action label from
   action_dispatch.request.parameters. This can lead to conflicts, where
   there's a form parameter called "action", or "controller" which takes
   precedence over "which controller action is this?".
   
   This can be validated with a curl request to a rails application
   instrumented with prometheus_exporter:
   
     curl -v http://127.0.0.1:3000/ --data 'controller=test'
   
   Results in:
   
     # HELP http_requests_total Total HTTP requests from web app.
     # TYPE http_requests_total counter
     http_requests_total{action="other",controller="test",status="404"} 1
   
   This commit pulls the controller instance from `action_controller.instance`,
   and then calls the controller_name / action_name methods, which should
   be accurate even when conflicting form parameters are provided.

   

   richardTowers committed Sep 29, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for dc41ee5
   • Browse repository at this point

   Copy the full SHA

   dc41ee5 View commit details

   Browse the repository at this point in the history