Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register PumaCollector in Server #40

Merged
merged 1 commit into from Oct 17, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/prometheus_exporter/server/collector.rb
Expand Up @@ -30,6 +30,7 @@ def initialize(json_serializer: nil)
register_collector(ProcessCollector.new)
register_collector(SidekiqCollector.new)
register_collector(DelayedJobCollector.new)
register_collector(PumaCollector.new)
end

def register_collector(collector)
Expand Down
1 change: 1 addition & 0 deletions prometheus_exporter.gemspec
Expand Up @@ -30,5 +30,6 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "guard-minitest", "~> 2.0"
spec.add_development_dependency "oj", "~> 3.0"
spec.add_development_dependency "rack-test", "~> 0.8.3"
spec.add_development_dependency "minitest-stub-const", "~> 0.6"
spec.required_ruby_version = '>= 2.3.0'
end
25 changes: 25 additions & 0 deletions test/server/collector_test.rb
Expand Up @@ -234,4 +234,29 @@ def test_it_can_collect_delayed_job_metrics_with_custom_labels
failed_job.verify
end

require 'minitest/stub_const'

def test_it_can_collect_puma_metrics
collector = PrometheusExporter::Server::Collector.new
client = PipedClient.new(collector)

mock_puma = Minitest::Mock.new
mock_puma.expect(
:stats,
'{ "workers": 1, "phase": 0, "booted_workers": 1, "old_workers": 0, "worker_status": [{ "pid": 87819, "index": 0, "phase": 0, "booted": true, "last_checkin": "2018-10-16T11:50:31Z", "last_status": { "backlog":0, "running":8, "pool_capacity":32, "max_threads": 32 } }] }'
)

instrument = PrometheusExporter::Instrumentation::Puma.new

Object.stub_const(:Puma, mock_puma) do
metric = instrument.collect
client.send_json metric
end

result = collector.prometheus_metrics_text
assert(result.include?("puma_booted_workers_total 1"), "has booted workers")
assert(result.include?("puma_request_backlog_total 0"), "has total backlog")
assert(result.include?("puma_thread_pool_capacity_total 32"), "has pool capacity")
mock_puma.verify
end
end