Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete old metrics in puma collector #80

Closed
wants to merge 1 commit into from
Closed

delete old metrics in puma collector #80

wants to merge 1 commit into from

Conversation

Fivell
Copy link
Contributor

@Fivell Fivell commented Jul 9, 2019

refs #69 #34

@Fivell
Copy link
Contributor Author

Fivell commented Jul 9, 2019

image

@Fivell Fivell force-pushed the fix_puma_collector_leak branch 4 times, most recently from cd5adc8 to 261b974 Compare July 9, 2019 15:32
@Fivell
Copy link
Contributor Author

Fivell commented Jul 9, 2019 •
edited

@SamSaffron can't figure out why travis fails randomly with Errno::ECONNRESET: Connection reset by peer - connect(2) for "localhost" port 12437 , seems some technical problem

eviltrout
eviltrout reviewed Jul 9, 2019
View reviewed changes
lib/prometheus_exporter/server/puma_collector.rb Outdated
obj["created_at"] = now

@puma_metrics.delete_if do |current|
(obj["pid"] == current["pid"] && obj["hostname"] == current["hostname"]) ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look at the puma collector and I don't think pid and hostname are included in the obj?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eviltrout you're right , seems we need to leave only current["created_at"] + MAX_PUMA_METRIC_AGE < now

@eviltrout
Copy link
Contributor

Thanks, I adapted this in e2d75a5 and credited you as a co-author.

@eviltrout eviltrout closed this Jul 9, 2019
@Fivell Fivell deleted the fix_puma_collector_leak branch July 9, 2019 18:00
@Fivell Fivell restored the fix_puma_collector_leak branch July 9, 2019 18:00
@Fivell Fivell deleted the fix_puma_collector_leak branch July 9, 2019 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eviltrout eviltrout eviltrout left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Fivell @eviltrout