DEV: Fix reading_role/writing_role deprecations #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced in rails/rails#42445 Example of a warning: ``` DEPRECATION WARNING: ActiveRecord::Base.writing_role is deprecated and will be removed in Rails 7.1. Use `ActiveRecord.writing_role` instead. (called from block (2 levels) in <top (required)> at /__w/discourse/discourse/spec/rails_helper.rb:304) ```
|
Ping @CvX |
CvX
force-pushed
the
ar-deprecations
branch
23 times, most recently
from
e0ac6da
to
b6eb199
Compare
CvX
force-pushed
the
ar-deprecations
branch
2 times, most recently
from
485b8f6
to
66e27bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in rails/rails#42445
Example of a warning: