DEV: Remove JS depedencies in dummy app #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why this change? We have been getting Github vulnerability alerts due to the JS dependencies in the dummy app. However, there is no way to configure dependabot to exclude scanning certain directories at this moment. See dependabot/dependabot-core#4364. At such, we will just nuke the JS dependencies from the dummy app to stop the noise.
tgxworld
force-pushed
the
remove_javascript_dependencies_in_dummy_app
branch
from
d429676
to
5a8dc13
Compare
martin-brennan
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change?
We have been getting Github vulnerability alerts due to the JS
dependencies in the dummy app. However, there is no way to configure
dependabot to exclude scanning certain directories at this moment. See
dependabot/dependabot-core#4364.
At such, we will just nuke the JS dependencies from the dummy app to
stop the noise.